Fixes Coverity CID 709289: Explicit null dereferenced (FORWARD_NULL)
Assigning: "effectToMove" = 0.
790    CollapsibleEffect *effectToMove = NULL;
...
Passing null variable "effectToMove" to function 
"CollapsibleGroup::addGroupEffect(CollapsibleEffect *)", which dereferences it. 
[show details]
805    group->addGroupEffect(effectToMove);
---
 src/effectstack/effectstackview2.cpp |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/effectstack/effectstackview2.cpp 
b/src/effectstack/effectstackview2.cpp
index c345272..740518c 100644
--- a/src/effectstack/effectstackview2.cpp
+++ b/src/effectstack/effectstackview2.cpp
@@ -802,7 +802,8 @@ void EffectStackView2::slotCreateGroup(int ix)
     connectGroup(group);
     l->insertWidget(groupPos, group);
     group->installEventFilter( this );
-    group->addGroupEffect(effectToMove);
+    if (effectToMove)
+        group->addGroupEffect(effectToMove);
 }
 
 void EffectStackView2::connectGroup(CollapsibleGroup *group)
-- 
1.7.10.4


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Kdenlive-devel mailing list
Kdenlive-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kdenlive-devel

Reply via email to