> On Sept. 18, 2016, 9:57 a.m., Jean-Baptiste Mardelle wrote:
> > src/monitor/monitor.cpp, line 950
> > <https://git.reviewboard.kde.org/r/128929/diff/1/?file=476999#file476999line950>
> >
> >     Minor issue, but if the project has not yet been saved, and attempting 
> > to add a frame to project from timeline, the suggested name is:
> >     "-f320.png" since project url is empty. Might be better to preprend 
> > i18n("untitled") in case there is no project url.

For some reason I assumed the project URL to contain "unnamed", but did not 
thoroughly check. Updated patch now checks that project URL isValid() and 
otherwise uses i18n("untitled"). This now works as expected.


- The


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128929/#review99250
-----------------------------------------------------------


On Sept. 18, 2016, 1:18 p.m., The DiveO wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128929/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2016, 1:18 p.m.)
> 
> 
> Review request for Kdenlive.
> 
> 
> Repository: kdenlive
> 
> 
> Description
> -------
> 
> This patch adds the ability to not only extract a frame (in the monitors), 
> but to immediately add it to the project for further use.
> - For the UI design, this is a separate function, not folded into the 
> existing "Save Image" dialog. Instead, the user now has an additional menu 
> item "Extract frame to project...".
> - When using "Extract frame to project", the following "Save Image to 
> Project" file saver dialog proposes a (hopefully) suitable image file name. 
> It bases on either the clip name (when invoked from the clip monitor) or the 
> project name (when invoked from the project monitor), and the number of the 
> frame extracted. This allows for a smooth workflow when extracting multiple 
> still images from the same video clip.
> - The two menu items for extracting images are corrected to end in "...", as 
> with both menu items the user will see a dialog following menu item selection.
> - The patch avoids duplicating code, so slotExtractCurrentFrame is used for 
> both extraction, and the optional add-to-project step. This is achieved using 
> an optional flag. The new menu item is wired up to 
> slotExtractCurrentFrameToProject, which simply reroutes to 
> slotExtractCurrentFrame using the optional flag.
> 
> 
> Diffs
> -----
> 
>   src/monitor/monitor.h 39679d8 
>   src/monitor/monitor.cpp 8d77d8b 
> 
> Diff: https://git.reviewboard.kde.org/r/128929/diff/
> 
> 
> Testing
> -------
> 
> Testing on recent Kdenlive git master.
> 
> 
> Thanks,
> 
> The DiveO
> 
>

Reply via email to