On Sun, Aug 16, 2009 at 08:18:21PM -0700, Glenn Barry wrote:
>  Will Fiveash wrote:
> > On Thu, Aug 06, 2009 at 11:37:55PM -0700, Glenn Barry wrote:
> >   
> >>  Here's the MIT Kerb 1.7 PAC&SPNEGO resync.
> >>
> >>  61 total files, split into 5 chunks.
> >>
> >>  By next Wed would be great, sooner even better as we are trying to make  
> >> snv_122.
> >>
> >>  thx...glenn
> >>
> >>  http://cr.opensolaris.org/~gtb/mit17-pac-spnego/webrev/
> >>
> >>  chunk1  WillF
> >>  usr/src/cmd/gss/gssd/gssd_clnt_stubs.c
> >>  ...
> >>  usr/src/lib/gss_mechs/mech_krb5/krb5/asn.1/krbasn1.h
> >>     
> >
> > It would be better if the CRs listed under each file in the webrev were
> > limited to those that are actually relevant to the change in the file.
> > For example usr/src/cmd/gss/gssd/gssd_clnt_stubs.c lists:
> >
> >     PSARC 2009/418 Kerberos V5 PAC API
> >     6283931 SPNEGO needs to follow latest RFC
> >     6808598 krb5 APIs needed to create and parse PAC data
> >     6817447 libgss and various mechs are hiding both the real minor_status 
> > and the error token
> >
> > but the changes appears to only involve:
> >     6817447 libgss and various mechs are hiding both the real minor_status 
> > and the error token
> >
> >   
>  gtb: so yea we discussed this in our Wed mtg.  To summarize: yea,
>  would be better I agree.  But this method is legal for push to onnv now,
>  correct?  And there is a hg extensition to allow 1 changeset per CR in
>  same workspace avail soon? (now?)  thx.

The patch queue hg extension can help here.  Mark Phalan sent a message
about this several months ago and I've been playing with it and taking
notes.  I'll blog it and will let you know when done.

-- 
Will Fiveash
Sun Microsystems Inc.
http://opensolaris.org/os/project/kerberos/
Sent from mutt, a sweet ASCII MUA

Reply via email to