Glenn Barry wrote: > ... > chunk2 Shawn > usr/src/lib/gss_mechs/mech_krb5/krb5/krb/chpw.c > ... > usr/src/lib/gss_mechs/mech_krb5/mech/oid_ops.c > ...
usr/src/lib/gss_mechs/mech_krb5/krb5/krb/pac.c: 44: Should be "Solaris Kerberos" or "Solaris Kerberos:SUNW17PACresync" 48: load_16_le, et. al. are already defined in usr/src/uts/common/gssapi/mechs/krb5/include/k5-platform.h 134: extra blank line 426, etc.: is there precedence in using system errno's such as this? 494: only returns non-error, so can return void 654,879: s/SUNW17PACresync/Solaris Kerberos:SUNW17PACresync/ usr/src/lib/gss_mechs/mech_krb5/mapfile-vers: 217: comment should be removed, no? usr/src/lib/gss_mechs/mech_krb5/mech/accept_sec_context.c 818: Is this comment in MIT's source? 1185: s/SUNW17PACresync/Solaris Kerberos:SUNW17PACresync/ 1191: doesn't check to make sure if memory was allocated 1192: should use sizeof for length. usr/src/lib/gss_mechs/mech_krb5/mech/inq_context.c 130: s/SUNW17PACresync/Solaris Kerberos:SUNW17PACresync/ 271: overloading system error codes again 272: why not just return the prior major_status code if non-zero? usr/src/lib/gss_mechs/mech_krb5/mech/krb5_gss_glue.c 343: s/SUNW17PACresync/Solaris Kerberos:SUNW17PACresync/ 1397: is the first element always the one we want? 1403: why not memcpy()? usr/src/lib/gss_mechs/mech_krb5/mech/oid_ops.c 453, et. al.: overloading system error codes for minor statues again. The rest looks good. Thanks, Shawn. --
