Wyllys Ingersoll wrote: >>>>> chunk3 Wyllys >>>>> usr/src/lib/gss_mechs/mech_krb5/mech/rel_buffer.c >>>>> ... >>>>> usr/src/lib/gss_mechs/mech_spnego/sparcv9/Makefile >>>>> >>>>> > > > util_buffer_set.c > L76-79: Does this leak memory allocated from > "generic_gss_create_empty_buffer_set" on failure? > L83-87: Same as above + memory reallocated at 73. > > utf8.c > L284-287: Can these functions potentially be walking past (or prior) to > allocated space > L307-310: or do the calling functions ensure that they are passing proper > buffers ? > L337-342 > > spnego_mech.c - when does LEAN_CLIENT get defined? > L2640-2642 - Should check value of "length" before proceeding. > > The Makefiles look ok. > > -Wyllys > > util_buffer_set.c L76-79: Does this leak memory allocated from "generic_gss_create_empty_buffer_set" on failure? L83-87: Same as above + memory reallocated at 73.
gtb: yup, good catch. utf8.c L284-287: Can these functions potentially be walking past (or prior) to allocated space L307-310: or do the calling functions ensure that they are passing proper buffers ? L337-342 gtb: they all have a stopping condition: (u[i] & 0xc0) != 0x80) spnego_mech.c - when does LEAN_CLIENT get defined? gtb: yea, we don't set/need it so does not matter to us but will keep it there to stay in sync w/MIT. L2640-2642 - Should check value of "length" before proceeding. gtb: yup, added it. thanks...glenn
