On Sat, Jul 4, 2015 at 3:22 PM, Emmanuel Lécharny <[email protected]> wrote:
> Le 04/07/15 08:44, Kiran Ayyagari a écrit : > > On Sat, Jul 4, 2015 at 2:12 PM, Emmanuel Lécharny <[email protected]> > > wrote: > > > >> Le 04/07/15 07:55, Kiran Ayyagari a écrit : > >>> On Sat, Jul 4, 2015 at 1:52 PM, Emmanuel Lécharny <[email protected] > > > >>> wrote: > >>> > >>>> Le 04/07/15 07:49, Kiran Ayyagari a écrit : > >>>>> On Sat, Jul 4, 2015 at 1:20 PM, Zheng, Kai <[email protected]> > >> wrote: > >>>>>> Thanks Kiran. > >>>>>> > >>>>>>>> you need latest mavibot build in your local repo > >>>>>> Do we have to rely on this? Maybe we could use some public version? > If > >>>> not > >>>>>> then when could we have the new release version? > >>>>>> I do have the local build of Mavibot, but am not sure all Kerby > >>>> developers > >>>>>> do. > >>>>>> > >>>>> It is available in the repository > >>>>> https://repository.apache.org/content/groups/snapshots > >>>>> > >>>>> Those who do not want to build it locally can use this configuration > >>>>> http://apaste.info/qLE to set their > >>>>> maven setting.xml (either create new file or update existing > >> accordingly) > >>>> That's not a good idea, IMO. > >>>> > >>>> both are in development, so I don't see any issue with it > >>>> We should never depend on a SNAPSHOT. I'd rather cut a release of > >>>> MAVIBOT and make Kerby depend on this release, but in the mean time, I > >>>> strongly suggest the module not to be added (or to be commented) in > the > >>>> kerby build. > >>>> > >>> if a release version of Kerby depends on a snapshot then agree, but > that > >> is > >>> not the case here > >>> > >>> > >>> > >> No, even if it's not a release : depending on a SNAPSHOT is risky. It's > >> not like ApacheDS which depends on the API and Mavibot SNAPSHOT, because > >> we can't imagine releasing apacheDS without releasing Mavibot and the > >> API first. That creates a dependency on an external project that is > >> problematic. > >> > >> Here, what I would suggest is to add a maven profile, so that you can > >> build Kerby with a Mavibot SNAPSHOT, like : mvn -Pmavibot > >> > >> Now, I see where you are coming from, and from a develoment POV, your > >> choice make sense. It's just that for others, it breaks the build. > >> > >> Here is what we should do : cut a MAVIBOT release, now. That would solve > >> the issue. > >> > >> +1 > >> wdyt ? > >> > > we are going to release Mavibot soon anyway, I was just pointing that it > is > > not a blocker for > > building kerby with mavibot module, and maven is there to solve cases > like > > this. > This is not the right way to use Maven : you are just telling anyone > that will download Kerby source that they are to tune their > settings.xml. It's not flying ! > I was just letting those new kerby developers who I think are new to maven. > > Also consider that the buldbot is failing, generating errors that we all > receive, and we have no way to change the buildbot settings.xml. > > I will look into it, wonder why snapshot repo is not added by default in the buildbot I might just add repository tag in pom.xml to fix this for everybody > Add a Maven profile if you are to use a Mavibot SNAPSHOT. > > sorry, if I thought this is the right way to do I would have done it, but it is counter intuitive developers are supposed to figure out their tools and environment issues. -- Kiran Ayyagari http://keydap.com
