Public bug reported:

A typo at line 184 in /drivers/usb/host/xhci-pci.c trashes a good fix.


183         if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
184                         pdev->device == 0x0014)
185                 xhci->quirks |= XHCI_TRUST_TX_LENGTH;
186         if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
187                         pdev->device == 0x0015)
188                 xhci->quirks |= XHCI_RESET_ON_RESUME;

Line 184 should be identical to line 187, ie: should read pdev->device
== 0x0015)

I've compiled the kernel both with and without the typo. As written,
hundreds of messages fill dmesg suggesting XHCI_TRUST_TX_LENGTH may be
needed when zoneminder tries to access my USB webcams. With the fix
applied as I've suggested the messages disappear.

The typo is still present in 4.15.0-22.24

For more background, you may refer to bug ID #1710548

** Affects: linux (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1773704

Title:
  Typo at line 184 in xhci-pci.c makes trouble for Renesas USB chipset
  in Bionic 18.04

Status in linux package in Ubuntu:
  New

Bug description:
  A typo at line 184 in /drivers/usb/host/xhci-pci.c trashes a good fix.

  
  183         if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
  184                         pdev->device == 0x0014)
  185                 xhci->quirks |= XHCI_TRUST_TX_LENGTH;
  186         if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
  187                         pdev->device == 0x0015)
  188                 xhci->quirks |= XHCI_RESET_ON_RESUME;

  Line 184 should be identical to line 187, ie: should read pdev->device
  == 0x0015)

  I've compiled the kernel both with and without the typo. As written,
  hundreds of messages fill dmesg suggesting XHCI_TRUST_TX_LENGTH may be
  needed when zoneminder tries to access my USB webcams. With the fix
  applied as I've suggested the messages disappear.

  The typo is still present in 4.15.0-22.24

  For more background, you may refer to bug ID #1710548

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773704/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to