* Neil Horman <[EMAIL PROTECTED]> wrote:

>       if (!user_mode_vm(regs)) {
> +             nmi_exit();
> +             local_irq_enable();
>               current->thread.trap_no = 2;
>               crash_kexec(regs);

looks good to me, but please move the local_irq_enable() to within 
crash_kexec() instead - probably inside the "got the kexec lock" 
section. That makes crash_kexec() use generally safer too i guess: right 
it seems that die() too can call crash_kexec() with irqs disabled - and 
can thus hang in smp_send_stop() [or wherever it hung before].

        Ingo

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

Reply via email to