* Huang Ying <[EMAIL PROTECTED]> wrote:
> +/* Ftrace disable/restore without lock. Some synchronization mechanism
> + * must be used to prevent ftrace_enabled to be changed between
> + * disable/restore. */
use the proper comment style please:
/*
*
*/
> +static inline int __ftrace_enabled_save(void)
> +{
> +#ifdef CONFIG_FTRACE
> + int saved_ftrace_enabled = ftrace_enabled;
> + ftrace_enabled = 0;
> + return saved_ftrace_enabled;
> +#else
> + return 0;
> +#endif
> +}
> +
> +static inline void __ftrace_enabled_restore(int enabled)
> +{
> +#ifdef CONFIG_FTRACE
> + ftrace_enabled = enabled;
> +#endif
> +}
hm, what is this used for?
also, instead of such an ugly inline, why not create a proper
kernel/trace/* function for this. That would also give it access to all
the proper locking mechanisms - instead of relying on some extral
mechanism.
Ingo
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
