Simon Horman schrieb:
>  
> +
> +     if ( NULL == p)
> +             return -1;

Wouldn't that be better 'p == NULL'?

> +     ret = strtol(line, &p, 10);
> +
> +     /* Too long */
> +     if (ret > INT_MAX)
> +             return -1;

An integer that can be represented in 2 (strlen("__\0")==3) cannot be
larger than INT_MAX on any platform I can imagine. ;-)




Regards,
Bernhard

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

Reply via email to