On 02/10/2012 03:15 PM, Atsushi Kumagai wrote:
Hi, Suzuki

On Wed, 18 Jan 2012 15:40:03 +0530
"Suzuki K. Poulose"<[email protected]>  wrote:

Mostly a copy of ppc64 with renaming to _ppc variants.

Signed-off-by: Suzuki K. Poulose<[email protected]>
---

  Makefile       |   11 ++++--
  arch/ppc.c     |  101 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  makedumpfile.c |    4 +-
  makedumpfile.h |   24 ++++++++++++-
  4 files changed, 133 insertions(+), 7 deletions(-)
  create mode 100644 arch/ppc.c

I will make small changes:

diff --git a/makedumpfile.c b/makedumpfile.c
index cefb7cf..901b85c 100644
--- a/makedumpfile.c
+++ b/makedumpfile.c
@@ -5693,7 +5693,7 @@ initial_xen(void)

  #if defined(__powerpc64__) || defined(__powerpc32__)
         MSG("\n");
-       MSG("xen is not supported on powerpc.\n");
+       MSG("Xen is not supported on powerpc.\n");
         return FALSE;
  #else
         if(!info->flag_elf_dumpfile) {
diff --git a/makedumpfile.h b/makedumpfile.h
index 88b7bc2..e43ea84 100644
--- a/makedumpfile.h
+++ b/makedumpfile.h
@@ -686,7 +686,7 @@ unsigned long long vaddr_to_paddr_ppc(unsigned long vaddr);
  #define get_machdep_info()     get_machdep_info_ppc()
  #define get_versiondep_info()  TRUE
  #define vaddr_to_paddr(X)      vaddr_to_paddr_ppc(X)
-#endif          /* powerpc */
+#endif          /* powerpc32 */

  #ifdef __s390x__ /* s390x */
  int get_machdep_info_s390x(void);


The other parts looks good.
I will merge this patch to makedumpfile-1.4.3.

By the way, could you tell me kernel versions that you've tested ?
I want to update "SUPPORTED KERNELS" in the README.

I have tested this on 3.2.0. Eventhough the makedumpfile says the kernel
is not supported, the dumps work fine.

Thanks
Suzuki


_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

Reply via email to