On Thursday 23 February 2012 03:05 PM, Atsushi Kumagai wrote:
Hi Atsushi,
Hi Aruna,
On Wed, 1 Feb 2012 13:15:18 +0900
Atsushi Kumagai<[email protected]> wrote:
Hi Aruna,
On Tue, 31 Jan 2012 15:56:33 +0530
Aruna Balakrishnaiah<[email protected]> wrote:
The patch fixes the segmentation fault issue of makedumpfile when a
user specifies an invalid file name with -x/--split option.
The patch takes care of such a scenario by setting .find_debuginfo to
a function pointer which returns -1 and throws error messages against
invalid vmlinux file input. With a valid vmlinux file .find_debuginfo
was never invoked since the absolute path of debuginfo was known by the
time we call init_dwarf_info.
Signed-off-by: Aruna Balakrishnaiah<[email protected]>
---
dwarf_info.c | 25 +++++++++++++++++++++++++
1 files changed, 25 insertions(+), 0 deletions(-)
I'm reviewing your patch and it looks good.
However, I can't guess that the segmentation fault caused
by --split option because --split option doesn't require an argument.
Would you tell me the case that you thought.
This is the case,
makedumpfile --split -x /boot/vmlinuz vmcore vm1 vm2
when used compressed vmlinux with -x.
Thanks,
Aruna
Thanks
Atsushi Kumagai
--
Regards,
Aruna Balakrishnaiah<[email protected]>
Linux Technology Center,
IBM India Systems and Technology Lab
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
