Sorry, the format is not good. I will rearrange the patches and repost. So NACK these patches.
Maybe they should be put in one patch since they are used to remove the coverity scan error report. ----- Original Message ----- > From: "Chao Fan" <[email protected]> > To: [email protected] > Cc: "Chao Fan" <[email protected]> > Sent: Monday, August 24, 2015 11:15:52 AM > Subject: [PATCH]makedumpfile.c: check rhe return value ofset_page_size > > check_return: Calling function "set_page_size" without checking > return value (as is done elsewhere 5 out of 6 times). > > makedumpfile.c:8793: example_checked: "set_page_size(dh.block_size)" > has its value checked in "set_page_size(dh.block_size)". But in > makedumpfile.c:3213, the function "set_page_size" will not check > the return value. > > Signed-off-by: Chao Fan <[email protected]> > --- > makedumpfile.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/makedumpfile.c b/makedumpfile.c > index 32f5459..53efc04 100644 > --- a/makedumpfile.c > +++ b/makedumpfile.c > @@ -3213,7 +3213,8 @@ initial(void) > MSG("because the cyclic mode doesn't support sadump > format.\n"); > } > > - set_page_size(sadump_page_size()); > + if (!set_page_size(sadump_page_size())) > + return FALSE; > > if (!sadump_initialize_bitmap_memory()) > return FALSE; > -- > 2.4.3 > > > _______________________________________________ > kexec mailing list > [email protected] > http://lists.infradead.org/mailman/listinfo/kexec > _______________________________________________ kexec mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kexec
