On 03/08/17 at 09:13pm, Philip Prindeville wrote: > Inline… > > > > On Mar 5, 2017, at 6:46 PM, Dave Young <[email protected]> wrote: > > > > On 03/03/17 at 11:52am, Baoquan He wrote: > >> Kernel symbol page_offset_base could be unavailable when mm KASLR code is > >> not compiled in kernel. It's unappropriate to print out error message > > I subscribed to the list the day after this patch went out… Anyway, change > to “inappropriate”.
Indeed, not sure if Simon want a repost. Thanks, nice catch! > > -Philip > > > >> when failed to search for page_offset_base from /proc/kallsyms. Seems now > >> there is not a way to find out if mm KASLR is compiled in or not. An > >> alternative approach is only printing out debug message in get_kernel_sym > >> if failed to search a expected kernel symbol. > >> > >> Do it in this patch, a simple fix. > >> > >> Signed-off-by: Baoquan He <[email protected]> > >> --- > >> kexec/arch/i386/crashdump-x86.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/kexec/arch/i386/crashdump-x86.c > >> b/kexec/arch/i386/crashdump-x86.c > >> index 88aeee3..c4cf201 100644 > >> --- a/kexec/arch/i386/crashdump-x86.c > >> +++ b/kexec/arch/i386/crashdump-x86.c > >> @@ -127,7 +127,7 @@ static unsigned long long get_kernel_sym(const char > >> *symbol) > >> } > >> } > >> > >> - fprintf(stderr, "Cannot get kernel %s symbol address\n", symbol); > >> + dbgprintf("Cannot get kernel %s symbol address\n", symbol); > >> return 0; > >> } > >> > >> -- > >> 2.5.5 > >> > > > > It looks reasonable to me: > > > > Acked-by: Dave Young <[email protected]> > > > > Thanks > > Dave > _______________________________________________ kexec mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kexec
