On Friday 26 May 2017 07:17 AM, Atsushi Kumagai wrote:
write_vmcoreinfo_data(void)
{
        /*
+        * write 1st kernel's KERNELOFFSET
+        */
+       if (info->kaslr_offset)
+               fprintf(info->file_vmcoreinfo, "%s%lx\n", STR_KERNELOFFSET,
+                   info->kaslr_offset);
When will this data written to VMCOREINFO file be used ?
info->kaslr_offset is necessary for vmlinux but -x and -i are exclusive.
This is what I thought:

Lets says we have got a vmcore1 after re-filtering original vmcore. Now, if we
would like to re-filter vmcore1 then we will need kaslr_offset again. So,
should we not right kaslr_offset in vmcoreinfo of vmcore1 as well?
write_vmcoreinfo_data() is called only for -g option, it makes a
VMCOREINFO file as a separate file, it doesn't overwrite VMCOREINFO in vmcore.

OK..got it.

Will remove this function and send v4.


Thanks

~Pratyush

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

Reply via email to