On Wed, Jul 4, 2018 at 12:15 AM, Kazuhito Hagio <k-ha...@ab.jp.nec.com> wrote:
> On 7/3/2018 1:23 AM, Bhupesh Sharma wrote:
>> Hello Kazu-san,
>>
>> On Sat, Jun 30, 2018 at 3:18 AM, Bhupesh Sharma <bhsha...@redhat.com> wrote:
>>> Patch f49ca13e5eed5bbdc69e0fd5ef099cb46050cb3d added '--mem-usage'
>>> support for arm64 architecture.
>>>
>>> However, we also need to make sure that the calculation of
>>> 'page_offset' is valid in case we are running cases other than
>>> '--mem-usage'.
>>>
>>> This patch does the same. I tested this patch on my qualcomm and apm
>>> mustang arm64 boards.
>>>
>>> Signed-off-by: Bhupesh Sharma <bhsha...@redhat.com>
>>> ---
>>> arch/arm64.c | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/arch/arm64.c b/arch/arm64.c
>>> index c9dab677f2c9..2fd3e1874376 100644
>>> --- a/arch/arm64.c
>>> +++ b/arch/arm64.c
>>> @@ -222,6 +222,12 @@ get_stext_symbol(void)
>>> int
>>> get_machdep_info_arm64(void)
>>> {
>>> + /* Check if va_bits is still not initialized. If still 0, call
>>> + * get_versiondep_info() to initialize the same.
>>> + */
>>> + if (!va_bits)
>>> + get_versiondep_info_arm64();
>>> +
>>> if (!calculate_plat_config()) {
>>> ERRMSG("Can't determine platform config values\n");
>>> return FALSE;
>>> --
>>> 2.7.4
>>>
>>
>> This is an important fix for arm64 makedumpfile as it fixes issues
>> reported with Fedora when we use makedumpfile for cases other than
>> '--mem-usage'.
>>
>> So kindly consider this one for the next makedumpfile release.
>
> Hi Bhupesh,
>
> I understood its importance and I think that this problem should be
> fixed before the v1.6.4 release. Thanks for letting me know it.
>
> I've reviewed the patch and the process flow of arm64 architecture
> around it. It looks good to me, and applied.
Great. Thanks a lot for your help.
Regards,
Bhupesh
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
