This is a note to let you know that I've just added the patch titled

    kexec, KEYS, s390: Make use of built-in and secondary keyring for signature 
verification

to the 5.4-stable tree which can be found at:
    
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     
kexec-keys-s390-make-use-of-built-in-and-secondary-keyring-for-signature-verification.patch
and it can be found in the queue-5.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.


>From 0828c4a39be57768b8788e8cbd0d84683ea757e5 Mon Sep 17 00:00:00 2001
From: Michal Suchanek <[email protected]>
Date: Thu, 14 Jul 2022 21:40:27 +0800
Subject: kexec, KEYS, s390: Make use of built-in and secondary keyring for 
signature verification

From: Michal Suchanek <[email protected]>

commit 0828c4a39be57768b8788e8cbd0d84683ea757e5 upstream.

commit e23a8020ce4e ("s390/kexec_file: Signature verification prototype")
adds support for KEXEC_SIG verification with keys from platform keyring
but the built-in keys and secondary keyring are not used.

Add support for the built-in keys and secondary keyring as x86 does.

Fixes: e23a8020ce4e ("s390/kexec_file: Signature verification prototype")
Cc: [email protected]
Cc: Philipp Rudo <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Michal Suchanek <[email protected]>
Reviewed-by: "Lee, Chun-Yi" <[email protected]>
Acked-by: Baoquan He <[email protected]>
Signed-off-by: Coiby Xu <[email protected]>
Acked-by: Heiko Carstens <[email protected]>
Signed-off-by: Mimi Zohar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
 arch/s390/kernel/machine_kexec_file.c |   18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

--- a/arch/s390/kernel/machine_kexec_file.c
+++ b/arch/s390/kernel/machine_kexec_file.c
@@ -29,6 +29,7 @@ int s390_verify_sig(const char *kernel,
        const unsigned long marker_len = sizeof(MODULE_SIG_STRING) - 1;
        struct module_signature *ms;
        unsigned long sig_len;
+       int ret;
 
        /* Skip signature verification when not secure IPLed. */
        if (!ipl_secure_flag)
@@ -63,11 +64,18 @@ int s390_verify_sig(const char *kernel,
                return -EBADMSG;
        }
 
-       return verify_pkcs7_signature(kernel, kernel_len,
-                                     kernel + kernel_len, sig_len,
-                                     VERIFY_USE_PLATFORM_KEYRING,
-                                     VERIFYING_MODULE_SIGNATURE,
-                                     NULL, NULL);
+       ret = verify_pkcs7_signature(kernel, kernel_len,
+                                    kernel + kernel_len, sig_len,
+                                    VERIFY_USE_SECONDARY_KEYRING,
+                                    VERIFYING_MODULE_SIGNATURE,
+                                    NULL, NULL);
+       if (ret == -ENOKEY && IS_ENABLED(CONFIG_INTEGRITY_PLATFORM_KEYRING))
+               ret = verify_pkcs7_signature(kernel, kernel_len,
+                                            kernel + kernel_len, sig_len,
+                                            VERIFY_USE_PLATFORM_KEYRING,
+                                            VERIFYING_MODULE_SIGNATURE,
+                                            NULL, NULL);
+       return ret;
 }
 #endif /* CONFIG_KEXEC_SIG */
 


Patches currently in stable-queue which might be from [email protected] are

queue-5.4/kexec-keys-s390-make-use-of-built-in-and-secondary-keyring-for-signature-verification.patch

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

Reply via email to