On 19/07/2022 16:53, Guilherme G. Piccoli wrote: > The altera_edac panic notifier performs some data collection with > regards errors detected; such code relies in the regmap layer to > perform reads/writes, so the code is abstracted and there is some > risk level to execute that, since the panic path runs in atomic > context, with interrupts/preemption and secondary CPUs disabled. > > Users want the information collected in this panic notifier though, > so in order to balance the risk/benefit, let's skip the altera panic > notifier if kdump is loaded. While at it, remove a useless header > and encompass a macro inside the sole ifdef block it is used. > > Cc: Dinh Nguyen <[email protected]> > Cc: Petr Mladek <[email protected]> > Cc: Tony Luck <[email protected]> > Signed-off-by: Guilherme G. Piccoli <[email protected]> > > --- > > V2: > - new patch, based on the discussion in [0]. > [0] > https://lore.kernel.org/lkml/[email protected]/ > > drivers/edac/altera_edac.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > [...]
Hey Tony / Dinh, do you think this patch is good, based on the discussion we had [0] last iteration? Thanks in advance, Guilherme [0] https://lore.kernel.org/lkml/[email protected]/ _______________________________________________ kexec mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kexec
