On 2022/10/21 19:24, Leonidas Spyropoulos wrote:
> Version specific paths doesn't make sense at
> /usr/share/makedumpfile. This assumes you will have only one version
> installed which on a normal system it makes sense and devs can always
> specify different DESTDIR per versions.
>
> Fixes: #10
>
> Signed-off-by: Leonidas Spyropoulos <[email protected]>
Thanks for the patch.
I agree.
The patch [1] introduced the directory with ${VERSION}, but makedumpfile
has backward compatibility and the directory does not have any data that
has version restraint, so I don't see any reason. Also I didn't find any
discussion in the list archive.
I will merge this a few days later if no objection.
Thanks,
Kazu
[1]
https://github.com/makedumpfile/makedumpfile/commit/41e1ccfcd57736047a5c52d8096fbcaa255146ec
> ---
> Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 548e5b7..f6ecbe2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -130,6 +130,6 @@ install:
> install -m 755 -t ${DESTDIR}/usr/sbin makedumpfile
> $(VPATH)makedumpfile-R.pl
> install -m 644 -t ${DESTDIR}/usr/share/man/man8 makedumpfile.8
> install -m 644 -t ${DESTDIR}/usr/share/man/man5 makedumpfile.conf.5
> - mkdir -p ${DESTDIR}/usr/share/makedumpfile-${VERSION}/eppic_scripts
> - install -m 644 -D $(VPATH)makedumpfile.conf
> ${DESTDIR}/usr/share/makedumpfile-${VERSION}/makedumpfile.conf.sample
> - install -m 644 -t
> ${DESTDIR}/usr/share/makedumpfile-${VERSION}/eppic_scripts/
> $(VPATH)eppic_scripts/*
> + mkdir -p ${DESTDIR}/usr/share/makedumpfile/eppic_scripts
> + install -m 644 -D $(VPATH)makedumpfile.conf
> ${DESTDIR}/usr/share/makedumpfile/makedumpfile.conf.sample
> + install -m 644 -t ${DESTDIR}/usr/share/makedumpfile/eppic_scripts/
> $(VPATH)eppic_scripts/*
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
