On 11/2/22 04:26, Borislav Petkov wrote:
On Tue, Nov 01, 2022 at 10:45:00AM -0500, Eric DeVolder wrote:
As I'm re-reading that message, I suspect now the preference is to just to
strike this ifdiffery line in this file and have the code always present?

If the preference is actually for CRASH_HOTPLUG, then let me know.

Well, it is this part:

"But on a plain simple laptop or workstation which has CPU hotplug,
would it make sense for the crash ranges to get updated too when CPUs
are offlined?

Yes, it does.


If so, I think you want this code present there too, without a Kconfig
item."

Ah, ok.


IOW, if this thing doesn't make sense to have on the majority of
machines out there - and memory hotplug machines are not the majority -
then it should be behind a Kconfig item which is default off and gets
enabled only when the user selects crash and memory hotplug...

I'd say.


Ok, I'll will remove the ifdef line/pair.

Thanks!
eric

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Reply via email to