On Fri, Oct 20, 2023 at 09:49:59AM +0000, Huang, Kai wrote:
> On Thu, 2023-10-05 at 16:14 +0300, Kirill A. Shutemov wrote:
> > struct acpi_madt_multiproc_wakeup {
> > struct acpi_subtable_header header;
> > - u16 mailbox_version;
> > + u16 version;
> > u32 reserved; /* reserved - must be zero */
> > - u64 base_address;
> > + u64 mailbox_address;
> > + u64 reset_vector;
> > };
>
> I don't quite understand the connection between the renaming and what this
> patch
> wants to achieve? What's the reason to rename?
Names are bad: the version field guides version of the structure, not
version of the mailbox. And it is not clear what base base_address
specifies.
> If needed, perhaps put into a separate patch with proper justification?
Hm. Okay...
--
Kiryl Shutsemau / Kirill A. Shutemov
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
