When an error is detected, use pr_err() instead of pr_debug() to output
log message.

In addition, remove the unnecessary return from set_page_address().

Signed-off-by: Yuntao Wang <[email protected]>
---
 arch/x86/kernel/kexec-bzimage64.c | 2 +-
 mm/highmem.c                      | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/x86/kernel/kexec-bzimage64.c 
b/arch/x86/kernel/kexec-bzimage64.c
index a61c12c01270..472a45dbc79a 100644
--- a/arch/x86/kernel/kexec-bzimage64.c
+++ b/arch/x86/kernel/kexec-bzimage64.c
@@ -424,7 +424,7 @@ static void *bzImage64_load(struct kimage *image, char 
*kernel,
         * command line. Make sure it does not overflow
         */
        if (cmdline_len + MAX_ELFCOREHDR_STR_LEN > header->cmdline_size) {
-               pr_debug("Appending elfcorehdr=<addr> to command line exceeds 
maximum allowed length\n");
+               pr_err("Appending elfcorehdr=<addr> to command line exceeds 
maximum allowed length\n");
                return ERR_PTR(-EINVAL);
        }
 
diff --git a/mm/highmem.c b/mm/highmem.c
index e19269093a93..bd48ba445dd4 100644
--- a/mm/highmem.c
+++ b/mm/highmem.c
@@ -799,8 +799,6 @@ void set_page_address(struct page *page, void *virtual)
                }
                spin_unlock_irqrestore(&pas->lock, flags);
        }
-
-       return;
 }
 
 void __init page_address_init(void)
-- 
2.43.0


_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

Reply via email to