Unlock vmcore_mutex when returning -EBUSY.

Cc: David Hildenbrand <da...@redhat.com>
Cc: Andrew Morton <a...@linux-foundation.org>
Cc: Michael S. Tsirkin <m...@redhat.com>
Fixes: 0f3b1c40c652 ("fs/proc/vmcore: disallow vmcore modifications while the 
vmcore is open")
Signed-off-by: Bart Van Assche <bvanass...@acm.org>
---
 fs/proc/vmcore.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c
index a00120a3c099..10d01eb09c43 100644
--- a/fs/proc/vmcore.c
+++ b/fs/proc/vmcore.c
@@ -1524,7 +1524,7 @@ int vmcore_add_device_dump(struct vmcoredd_data *data)
                pr_warn_once("Unexpected adding of device dump\n");
        if (vmcore_open) {
                ret = -EBUSY;
-               goto out_err;
+               goto unlock;
        }
 
        list_add_tail(&dump->list, &vmcoredd_list);
@@ -1532,6 +1532,9 @@ int vmcore_add_device_dump(struct vmcoredd_data *data)
        mutex_unlock(&vmcore_mutex);
        return 0;
 
+unlock:
+       mutex_unlock(&vmcore_mutex);
+
 out_err:
        vfree(buf);
        vfree(dump);

Reply via email to