On Mon, 22 Sep 2025 15:31:42 -0700 "yanjun.zhu" <[email protected]> wrote:
> > +int kho_preserve_vmalloc(void *ptr, struct kho_vmalloc *preservation)
> > +{
> > + struct kho_vmalloc_chunk *chunk;
> > + struct vm_struct *vm = find_vm_area(ptr);
> > + unsigned int order, flags, nr_contig_pages;
> > + unsigned int idx = 0;
> > + int err;
>
> This is a trivial issue. I’m not sure whether RCT (Reverse Christmas
> Trees) is used in the Linux MM mailing list.
Not as far as I know. Some like it.
If I was to have a preference I'd suggest that things be laid out in a
logical order rather than by column count. Group like things together,
avoid use of unintialized storage in initializers(!).
