[email protected] writes: > >> diff --git a/virt/kvm/guest_memfd_luo.c b/virt/kvm/guest_memfd_luo.c >> index c242b1d14c0ac..8411fe86dc2a1 100644 >> --- a/virt/kvm/guest_memfd_luo.c >> +++ b/virt/kvm/guest_memfd_luo.c >> @@ -119,11 +119,11 @@ static bool kvm_gmem_luo_can_preserve(struct >> liveupdate_file_handler *handler, s >> /* >> * Only Fully-shared guest_memfd preservation is supported >> */ >> - if (GMEM_I(inode)->flags & GUEST_MEMFD_FLAG_INIT_SHARED) >> + if (!(GMEM_I(inode)->flags & GUEST_MEMFD_FLAG_INIT_SHARED)) >> return 0; > > [Severity: Medium] > Should this functional logic fix in kvm_gmem_luo_can_preserve() be split into > its own patch? > > The commit message explicitly states this is a documentation change, but this > modifies the condition for GUEST_MEMFD_FLAG_INIT_SHARED in C code, which > violates the rule of one logical change per commit and makes tracking bug > fixes difficult. >
OOOOPS, This (and the below) should be part of previous patch, I will have it fixed in next version next version. >> >> /* >> - * It makes sure that no memory can converted to private >> + * It makes sure that no memory can be converted to private >> * even if it was initially fully shared (in-place conversions are >> * prevented). >> */ > > -- > Sashiko AI review ยท > https://sashiko.dev/#/patchset/[email protected]?part=7
