On Wed 2022-11-09 10:50:43, John Ogness wrote:
> On 2022-11-09, Daniel Thompson <daniel.thomp...@linaro.org> wrote:
> >> @@ -463,9 +476,14 @@ static void kgdboc_earlycon_pre_exp_handler(void)
> >> * serial drivers might be OK with this, print a warning once per
> >> * boot if we detect this case.
> >> */
> >> - for_each_console(con)
> >> + cookie = console_srcu_read_lock();
> >> + for_each_console_srcu(con) {
> >> if (con == kgdboc_earlycon_io_ops.cons)
> >> - return;
> >> + break;
> >> + }
> >> + console_srcu_read_unlock(cookie);
> >> + if (con)
> >> + return;
> >
> > This change isn't mentioned in the patch description.
>
> I will move this change into its own separate patch.
>
> tty: serial: kgdboc: use srcu console list iterator
>
> Use srcu console list iteration for safe console list traversal.
Yes, split it please :-) Anyway, both changes look good to me.
Best Regards,
Petr
_______________________________________________
Kgdb-bugreport mailing list
Kgdb-bugreport@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
