2014-10-14 19:57 GMT+02:00 Wayne Stambaugh <[email protected]>: > On 10/14/2014 1:30 PM, Nick Østergaard wrote: >> I forgot about this patch, but I have now applied it and do not see >> any issue with it. I cannot comment on the code. >> >> But while testing it out I noticed that above the textbox it just says >> "Text" in a label. Shouldn't this be "Footprint name" or something >> similar? > > This dialog is generic for editing all fields not just the footprint > field. The problem is four of the fields are reserved, reference > designator, value, footprint, and document file. Changing "Text" to > something more descriptive for these four fields would be fairly simple. > User defined fields would be another story. I don't believe the > component field template code can store a description along with the > field name. In this case you would have to use something generic and > possibly confusing like "User Defined Field 1". I would leave it as > "Text" for now until a better solution can be found. The name of the > field is included in the dialog title so that does help somewhat.
Ok, I see. I just found it confusing that it was even there. It does not really matter much. I do not have a strong opinion on this. So I guess it is good as is. >> >> Nick >> >> 2014-10-14 17:24 GMT+02:00 Wayne Stambaugh <[email protected]>: >>> I've already applied the patch to my branch and did some testing. It >>> works as advertized but I just want to make sure we are for the most >>> part on board with the changes. I'll wait a while to make sure there >>> are no strong objections before I commit the changes. Thanks for the >>> feedback. >>> >>> Cheers, >>> >>> Wayne >>> >>> On 10/14/2014 11:15 AM, Brian Sidebotham wrote: >>>> Sorry, I didn't get much chance to look at it - but I liked the idea >>>> of it - I think this is one of the very reasons behind the KiWay work. >>>> It's certainly a bonus of that work which we should be reaping. >>>> >>>> I didn't get a chance to apply and test though. Let me know if you need >>>> that. >>>> >>>> Best Regards, >>>> >>>> Brian. >>>> >>>> On 14 October 2014 14:58, Wayne Stambaugh <[email protected]> wrote: >>>>> Has anyone else looked at this patch? If you haven't, it adds a select >>>>> button that launches the footprint viewer to select a footprint to the >>>>> edit field properties dialog when the footprint field is selected. I >>>>> personally like it but since it's behavioral change I would like some >>>>> input before I commit it. >>>>> >>>>> Thanks, >>>>> >>>>> Wayne >>>>> >>>>> On 10/11/2014 1:43 AM, Mark Roszko wrote: >>>>>> Hi, >>>>>> >>>>>> This patch makes the changes to add a selection button to the simple >>>>>> dialog that appears when you right-click on a component and choose >>>>>> Edit Component > Footprint. The button will open the footprint >>>>>> browser. This is just like the component property editor having the >>>>>> assign footprint button. >>>>>> + Doxygenization of the class. >>>>>> >>>>>> This also works in the library editor when you click on the footprint >>>>>> text and go to edit it. >>>>>> >>>>>> Patches attached and a bazr branch submitted for merge. >>>>>> >>>>>> https://code.launchpad.net/~mark-roszko/kicad/eeschema_footprint_pick >>>>>> >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>>> Post to : [email protected] >>>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>>> More help : https://help.launchpad.net/ListHelp >>>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>> Post to : [email protected] >>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>> More help : https://help.launchpad.net/ListHelp >>>> >>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : [email protected] >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >> > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
