Hey Mark, I just committed this patch to r5188 of the product branch. Thank you for you contribution to KiCad. I do have a few comments.
1) Doxygen comments do not belong in the source file. They belong in the header file. I moved them this time. 2) There was some trailing whitespace. 3) Please downgrade the your version of wxFormBuilder at least one revision. I know it's tempting to use the latest and greatest but for some users that means building it from source every time someone else edits a dialog box with a newer version. I usually try to stay at least one rev behind. It's also a good idea to announce on the mailing list if you want to use the latest version so the rest of us aren't caught off guard when we go to edit a dialog box. 4) Please submit a commit message along with the patch so I don't have to look at the diff to write the commit message. The preferred format is: General statement describing your patch. (fixes lp:xxxxx as required) * Details of each change and most importantly why you made the change. * More details * Even more detail Thanks, Wayne On 10/11/2014 1:43 AM, Mark Roszko wrote: > Hi, > > This patch makes the changes to add a selection button to the simple > dialog that appears when you right-click on a component and choose > Edit Component > Footprint. The button will open the footprint > browser. This is just like the component property editor having the > assign footprint button. > + Doxygenization of the class. > > This also works in the library editor when you click on the footprint > text and go to edit it. > > Patches attached and a bazr branch submitted for merge. > > https://code.launchpad.net/~mark-roszko/kicad/eeschema_footprint_pick > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
