Orson, I think the patch has been tested on all platforms so go ahead and commit it if you comfortable with the changes.
Thanks, Wayne On 12/7/2015 7:38 AM, Maciej Sumiński wrote: > Hi Cirilo, > > Thank you for the FindGLM script. I had to modify it slightly, as it did > not work with CMake 3.4.0 (problem with STREQUAL). > > Here is complete patch [1], that I applied to KiCad in order to use the > system glm library (0.9.7 in my case). If there are no problems with > other platforms/library versions, I guess it might be committed. > > Regards, > Orson > > 1. https://orson.net.pl/pub/glm.patch > > On 12/06/2015 11:17 PM, Cirilo Bernardo wrote: >> Thanks Bernhard, >> >> I just checked on MSYS2 and it works as well. Can someone push the >> FindGLM.cmake script on >> google drive into the kicad/CMakeModules directory? I'll create a branch >> later and see if there are >> any issues encountered when I delete the glm source from the tree and use >> find_package + >> include-directories. Even if there are any issues to be resolved, with the >> script installed Orson and >> Tom should be able to move the GAL code to the external glm lib whenever >> it's convenient. >> >> - Cirilo >> >> >> On Mon, Dec 7, 2015 at 8:55 AM, Bernhard Stegmaier <[email protected]> >> wrote: >> >>> … works fine on OS X with a MacPorts installed glm: >>> >>> bstegmaier$ cmake . >>> -- The CXX compiler identification is AppleClang 7.0.0.7000176 >>> -- The C compiler identification is AppleClang 7.0.0.7000176 >>> -- Check for working CXX compiler: >>> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ >>> -- Check for working CXX compiler: >>> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ >>> -- works >>> -- Detecting CXX compiler ABI info >>> -- Detecting CXX compiler ABI info - done >>> -- Detecting CXX compile features >>> -- Detecting CXX compile features - done >>> -- Check for working C compiler: >>> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc >>> -- Check for working C compiler: >>> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc >>> -- works >>> -- Detecting C compiler ABI info >>> -- Detecting C compiler ABI info - done >>> -- Detecting C compile features >>> -- Detecting C compile features - done >>> -- Found GLM: /opt/local/include/glm (found suitable version "0.9.6.3", >>> minimum required is "0.9.5.4") >>> -- Configuring done >>> -- Generating done >>> -- Build files have been written to: >>> /Volumes/OSXData/Users/bstegmaier/glm-test >>> >>> >>> Regards, >>> Bernhard >>> >>> On 06.12.2015, at 22:30, Cirilo Bernardo <[email protected]> >>> wrote: >>> >>> I've written a FindGLM script to help with the effort to remove glm source >>> code from >>> the kicad tree. This works on Linux (well, at least Debian) but needs >>> some testing >>> on MSYS2 and OSX. I believe this script is necessary because: >>> >>> 1. Different distributions are erratic in the inclusion of a FindGLM >>> script or the >>> newer glmConfig script. >>> 2. All other versions of the FindGLM script which I have seen are >>> defective - >>> they do not support version checking. >>> 3. The glmConfig script, even if it exists and is installed, is also >>> defective >>> since the version information is hard-coded into the CMakeLists.txt file >>> which generates the glmConfig script rather than taking the values from the >>> setup.hpp file. >>> 4. This script should work for all known versions of glm from the 0.9.4 >>> version >>> included in the kicad tree to the 0.9.8 development version. >>> >>> >>> https://drive.google.com/folderview?id=0By_XTJN-s8aXel9BZjA2ZFlGckU&usp=sharing >>> >>> - Cirilo >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : [email protected] >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >>> >>> >> >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : [email protected] >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> > > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
