Simon, I asked JP to take a look at this patch for me and he went ahead and fixed it which caught me a bit off guard. Apparently your patch had some issues in the ERC. I apologize for the confusion. I'm assuming you will have to revise your PinShape and electrical type patches to work with JP's changes.
Thanks, Wayne On 2/16/2016 1:34 PM, Simon Richter wrote: > > These enums are silently treated as equivalent in the ERC, because the > values are casted to integers. This works for the most part, because the > values are similar, but this is in no way enforced, and there is a small > inconsistency (NET_UNSPECIFIED vs PIN_PASSIVE). > > This turns the storage into a discriminated union, and provides an accessor > method that checks that a meaningful value can be returned and returns an > ElectricPinType in any case. > --- > eeschema/class_netlist_object.cpp | 36 ++++++++++++++++++++++++++++++++++-- > eeschema/class_netlist_object.h | 3 +++ > eeschema/erc.cpp | 8 ++++---- > 3 files changed, 41 insertions(+), 6 deletions(-) > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
