Hi, On 19.02.2016 21:40, Wayne Stambaugh wrote:
> I asked JP to take a look at this patch for me and he went ahead and > fixed it which caught me a bit off guard. Apparently your patch had > some issues in the ERC. I apologize for the confusion. I'm assuming > you will have to revise your PinShape and electrical type patches to > work with JP's changes. JP's patch seems to be more correct -- my assumption was that if the label orientation is copied to the ElectricalType field, it is also used for that (because otherwise there'd be no point copying it). If it isn't used, then simply using the enum type to make sure that no incompatible enum values are assigned, and fixing the two instances (init and sheet label orientation) is the right way to go. In the long run, it might be nice to warn people about sheet labels with the wrong orientation. My other patches have been rebased on top, I can easily resubmit them. Simon
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
