Le 23/04/2016 01:29, Cirilo Bernardo a écrit :
> Hi Wayne,
>
> The attached patch was made against r6709.
>
> - Cirilo
Cirilo, I just had a look at the patch, and noticed a (minor) issue:
you are searching an ENV VAR by searching "${"
This is perfectly true, but incomplete.
wxWidgets accepts both "${" and "$(". (and on windows accept also "%{" and "%("
and more)
The delimiters can be { and } or ( and )
They are equivalent in wxWidgets, and allows using ) or } in paths
(have a look at wxString wxExpandEnvVars(const wxString& str) in
src/common/config.cpp, perhaps it
could be used )
This in important because we are using both in Kicad.
for instance the fp lib wizard uses $(xxx) and in docs we use ${xxx} notation
Thanks.
>
>
> On Sat, Apr 23, 2016 at 12:52 AM, Wayne Stambaugh <[email protected]>
> wrote:
>
>> Cirilo,
>>
>> This patch no longer applies cleanly. Would you please fix it an repost
>> it.
>>
>> Thanks,
>>
>> Wayne
>>
--
Jean-Pierre CHARRAS
_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
