Assuming the general consensus is that this is okay to include, I'm going to have to ask you to make a few changes before it's accepted. I'll probably allow it myself if nobody specifically speaks up against it, it seems useful. However:
1) Please be careful to follow the established coding style. See Documentation/development/coding-style-policy.md in the source tree. In particular, function calls should be formatted like "f( args )", not "f(args)". 2) All of the dialogs/*_base.cpp and dialogs/*_base.h files are autogenerated from the dialogs/*_base.fbp files, which should be edited with wxformbuilder. Please don't edit them by hand, the edits will be lost the next time someone regenerates those files. I need you to redo your GUI modifications using wxformbuilder before I can merge this. Thank you for your contribution. -- Chris On Sun, Jun 12, 2016 at 05:25:21PM +0200, Cheng Sheng wrote: > Hi KiCad Developers, > > I made a feature for my own hobbyist use (to etch my own PCB boards). I > don't know how much the community welcomes such hobbyist-oriented features. > So I'd like to ask the mail-list before I send out a pull request. Guess > the answer leans positive because I already saw some hobbyist-friendly > features inside the "File->Print" dialog of pcbnew (eg., small drill). > > The use-case: vias of hobby-etched PCBs are usually hand-soldered with a > wire (I suppose most hobbyists don't eletroplate their through-holes), thus > needs to be exposed on the solder mask layers. Currently, the printed > images don't have vias on the solder mask layers. > > (It is still doable on the current version to produce a desired F.Mask or > B.Mask image by hacking the Gerber files, by overlaying a hacked drill file > on a mask Gerber file, and exporting in the Gerber viewer. But this is too > many steps to do.) > > Happily finding how easy it is to compile KiCad source code, I decide to > add the required functionality myself. Here it is: > http://bazaar.launchpad.net/~jeru-sheng/kicad/kicad-feature/revision/6924 > > What it does is: If a via appears on F.Cu layer, print it also on F.Mask > layer; same for B.Cu layer via on B.Mask layer. > > The new functionality is controllable in "File->Print" menu as a check box: > [image: Inline image 1] > > Given the following pcb traces: > [image: Inline image 4] > > When the check box is off: > [image: Inline image 2] > > When it is on: > [image: Inline image 3] > (so it seems the vias are on all copper layers, even if the traces it is > connected to are not on all layers). > > And this does not affect Gerber plot even when the check box is on: > [image: Inline image 5] > > Look forward to hearing back. > > Regards, > Cheng Sheng _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
