Looks good! Just a few comments:
I'd prefer to have the text "Specific via diameters and track width, ... track segments." wrap on dialog width and left aligned. The grey table header background color extend right of the tables. Looks odd. The Vias might need an additional assigned Layer-pair to be able to check that i.e. 100um uVias don't get drilled through all layers. Regards, Clemens On 2016-11-30 10:09, Oliver Walters wrote: > Ah, here's the actual screenshot: http://i.imgur.com/UQl0ziD.png > > On Wed, Nov 30, 2016 at 8:03 PM, Oliver Walters > <[email protected] <mailto:[email protected]>> > wrote: > > Hi All, > > This is a small patch that adds floating point validation to the VIA and > TRACK options in the Global Design Rules tab on the DRC dialog in pcbnew. > > The validators also prevent negative values from being entered. > > I have also swapped the radio buttons for checkboxes, and performed some > slight rearranging. Toggling the "Allow Micro Vias" box changes the enable > status of the micro via controls. > > Here is a screenshot: > blob:http://imgur.com/62c32a26-c6f7-46bd-b437-2ad99fabf579 > <http://imgur.com/62c32a26-c6f7-46bd-b437-2ad99fabf579> > > Patch is attached. > > Cheers, > Oliver > > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
