I finally got a chance to look at this patch. I like the changes for the most part. The check box and static text before text edit control strings should have sentence capitalization (not title capitalization) per our ui policy. I think moving the check boxes to the left would improve the layout. I also would consider getting rid of the "Track Options:" wxStaticBoxSizer. I don't think it makes a lot of sense to group a single item. Maybe use a single "Options" wxStaticBoxSizer for all of the options.
Cheers, Wayne On 11/30/2016 4:03 AM, Oliver Walters wrote: > Hi All, > > This is a small patch that adds floating point validation to the VIA and > TRACK options in the Global Design Rules tab on the DRC dialog in pcbnew. > > The validators also prevent negative values from being entered. > > I have also swapped the radio buttons for checkboxes, and performed some > slight rearranging. Toggling the "Allow Micro Vias" box changes the > enable status of the micro via controls. > > Here is a screenshot: > blob:http://imgur.com/62c32a26-c6f7-46bd-b437-2ad99fabf579 > > Patch is attached. > > Cheers, > Oliver > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
