Hi Kristoffer, I apologize for such a long delay. Finally I had to time to look at the patch. I tried it out with a few boards, but I could not really notice a difference. I read the code and I think I understand what are you trying to do, but are you sure it is the right way to go? Hierarchical sheets are frequently used as rooms/channels/duplicated blocks and in my opinion selecting items belonging to a sheet should be restricted to items unique to the sheet. Would you give a use case where the new behavior gives benefits?
Please pay attention to the code formatting, I see a number of violations there. Also, I observed a bug when selecting items belonging to the same sheet. If you open complex_hierarchy demo and use the select action on P3 or P5, you will notice that all components with a pad connected to GND are also selected. I can create a bug report if necessary. Regards, Orson On 07/11/2017 05:36 PM, Kristoffer Ödmark wrote: > Well, the sheet-selection code was all submitted by me in the first > place, It doesnt exist in legacy, so this change to how it works is > according to me more inline with what I wanted in the beginning :) > > - Kristoffer > > On 2017-07-10 21:06, Wayne Stambaugh wrote: >> Kristoffer, >> >> This appears to only effect the GAL canvases. Would one of our resident >> tool framework experts please take a look at this an see if it makes >> sense? If no one has time, I will try to get to it by this weekend. It >> will take most of the week for me to recover from vacation before I can >> take a look at it. >> >> Thanks, >> >> Wayne >> >> On 7/10/2017 11:21 AM, Kristoffer Ödmark wrote: >>> Hello! >>> >>> Second bump, I guess I might be the only one who uses the >>> sheet-selection then :) My suggestion is to merge this patch in, It >>> makes the selection more much more useful! >>> >>> - Kristoffer >>> >>> On 2017-06-06 13:44, Kristoffer Ödmark wrote: >>>> Hello again! >>>> >>>> I understand that everyone is pretty busy, but I would appreciate if >>>> someone took a quick glance at this and said what they think. >>>> >>>> - Kristoffer >>>> >>>> On 2017-05-03 15:51, Kristoffer Ödmark wrote: >>>>> Hello everyone! >>>>> >>>>> I made a small change to the "select hierarchical sheet" function. I >>>>> would love if someone tried this and gave some feedback. >>>>> >>>>> Before the function only selected segments belonging to a netlist >>>>> unique to that hierarchical sheet. Now it will use the "select >>>>> logical connection" to every segment connected to module from the >>>>> subsheet as well. presonally I think it is more useful now, but I >>>>> want confirmation if possible :) >>>>> >>>>> - Kristoffer >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : [email protected] >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : [email protected] >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
