I have not tested the patch, but the idea of having it also select tracks going of to the other sheets seems very useful.
2017-07-17 15:00 GMT+02:00 Kristoffer Ödmark <[email protected]>: > I fixed up some of the code violations I could see, and applied the patch > to current master, where the sheet selection is working once again. > > - Kristoffer > > > On 07/12/2017 10:01 PM, Kristoffer Ödmark wrote: > >> The last working revision I copuld test was: >> 2c21c70f46dd3ef444ac4a909434697cce972f4a >> >> Right before the new connectivty algorithm. >> >> After that the sheet-selection is not working anymore. So It would be >> nice if you could file a bug report on it :) >> >> - Kristoffer >> >> On 2017-07-12 13:33, Kristoffer Ödmark wrote: >> >>> No worries! >>> >>> As an example, If i layout a group of components, all which require >>> the powerpaths as in they need acess to 3v3 lines that are used in >>> other areas of the board as well. These 3v3 lines might be a bit >>> annoying to route for certain cases. >>> >>> As the code is now, since these 3v3 lines are used as an outside >>> connection of the sheet, they will be ignored, even if they only connect >>> between pads on the same subschematic. Say that the connection to the >>> global 3v3 net is handled later with a via or something like that. >>> >>> The same logic applies to all pins that connect outside the block, and >>> in some cases the layout of the blocks have a non-trivial routing to get >>> the signal out of the block "area", which is what i noticed when using >>> these. Hope this explanation made it more clear >>> >>> With this more aggressive change. It is also more visible from the pcb >>> side to where this "block" has dependencies, I also find it easier to >>> deselect segments manually, than to select them if the block is not very >>> trivial. >>> >>> Regarding the code violations, I will have a look later when I get the >>> time as well. >>> >>> the GND thing must indeed be a bug, which I will look into as well. >>> >>> On 07/12/2017 10:30 AM, Maciej Sumiński wrote: >>> >>>> Hi Kristoffer, >>>> >>>> I apologize for such a long delay. Finally I had to time to look at the >>>> patch. I tried it out with a few boards, but I could not really notice a >>>> difference. I read the code and I think I understand what are you trying >>>> to do, but are you sure it is the right way to go? Hierarchical sheets >>>> are frequently used as rooms/channels/duplicated blocks and in my >>>> opinion selecting items belonging to a sheet should be restricted to >>>> items unique to the sheet. Would you give a use case where the new >>>> behavior gives benefits? >>>> >>>> Please pay attention to the code formatting, I see a number of >>>> violations there. >>>> >>>> Also, I observed a bug when selecting items belonging to the same sheet. >>>> If you open complex_hierarchy demo and use the select action on P3 or >>>> P5, you will notice that all components with a pad connected to GND are >>>> also selected. I can create a bug report if necessary. >>>> >>>> Regards, >>>> Orson >>>> >>>> On 07/11/2017 05:36 PM, Kristoffer Ödmark wrote: >>>> >>>>> Well, the sheet-selection code was all submitted by me in the first >>>>> place, It doesnt exist in legacy, so this change to how it works is >>>>> according to me more inline with what I wanted in the beginning :) >>>>> >>>>> - Kristoffer >>>>> >>>>> On 2017-07-10 21:06, Wayne Stambaugh wrote: >>>>> >>>>>> Kristoffer, >>>>>> >>>>>> This appears to only effect the GAL canvases. Would one of our >>>>>> resident >>>>>> tool framework experts please take a look at this an see if it makes >>>>>> sense? If no one has time, I will try to get to it by this weekend. >>>>>> It >>>>>> will take most of the week for me to recover from vacation before I >>>>>> can >>>>>> take a look at it. >>>>>> >>>>>> Thanks, >>>>>> >>>>>> Wayne >>>>>> >>>>>> On 7/10/2017 11:21 AM, Kristoffer Ödmark wrote: >>>>>> >>>>>>> Hello! >>>>>>> >>>>>>> Second bump, I guess I might be the only one who uses the >>>>>>> sheet-selection then :) My suggestion is to merge this patch in, It >>>>>>> makes the selection more much more useful! >>>>>>> >>>>>>> - Kristoffer >>>>>>> >>>>>>> On 2017-06-06 13:44, Kristoffer Ödmark wrote: >>>>>>> >>>>>>>> Hello again! >>>>>>>> >>>>>>>> I understand that everyone is pretty busy, but I would appreciate if >>>>>>>> someone took a quick glance at this and said what they think. >>>>>>>> >>>>>>>> - Kristoffer >>>>>>>> >>>>>>>> On 2017-05-03 15:51, Kristoffer Ödmark wrote: >>>>>>>> >>>>>>>>> Hello everyone! >>>>>>>>> >>>>>>>>> I made a small change to the "select hierarchical sheet" function. >>>>>>>>> I >>>>>>>>> would love if someone tried this and gave some feedback. >>>>>>>>> >>>>>>>>> Before the function only selected segments belonging to a netlist >>>>>>>>> unique to that hierarchical sheet. Now it will use the "select >>>>>>>>> logical connection" to every segment connected to module from the >>>>>>>>> subsheet as well. presonally I think it is more useful now, but I >>>>>>>>> want confirmation if possible :) >>>>>>>>> >>>>>>>>> - Kristoffer >>>>>>>>> >>>>>>>> >>>>>>> _______________________________________________ >>>>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>>>> Post to : [email protected] >>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>>>> More help : https://help.launchpad.net/ListHelp >>>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>>> Post to : [email protected] >>>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>>> More help : https://help.launchpad.net/ListHelp >>>>>> >>>>>> >>>>> _______________________________________________ >>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>> Post to : [email protected] >>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>> More help : https://help.launchpad.net/ListHelp >>>>> >>>> >>>> >>>> >>>> >>>> _______________________________________________ >>>> Mailing list: https://launchpad.net/~kicad-developers >>>> Post to : [email protected] >>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>> More help : https://help.launchpad.net/ListHelp >>>> >>>> >>> > -- > -Kristoffer > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > >
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
