Hi Wayne, I understand. I am considering all your comments and I propose few minor improvements.
I will submitting a patch shortly with minor text and icon modifications. Cheers Fabrizio On Thu, Aug 10, 2017 at 7:16 PM, Wayne Stambaugh <[email protected]> wrote: > On 8/10/2017 12:56 PM, Fabrizio Tappero wrote: > > Hi Wayne, > > I understand. Maybe somebody else can clear up this issue. > > > > Regarding the "Archive Footprints in Footprint Library Table Entry", I > > am not sure people would actually know what a "library table entry", > > wouldn they? maybe "Archive Footprints in New Library"? > > It's hard to say but "Archive Footprints in New Library" is misleading. > If you are choosing a library from the library table, then it already > exists. Perhaps "Archive Footprints in Existing Library" would be less > confusing but the user will still be limited to fp lib table entries > rather than any path of the user's choosing. I also noticed that the > dialog showing the list of fp lib table entries for the user to select > showed all of the entries rather than only the entries that the user has > write permission so there is that issue as well. > > > > > cheers > > Fabrizio > > > > > > On Thu, Aug 10, 2017 at 6:33 PM, Wayne Stambaugh <[email protected] > > <mailto:[email protected]>> wrote: > > > > I'm not sure about this myself. I took a look at the code and I > still > > don't fully understand why there are multiple options. > > > > The ID_MENU_ARCHIVE_MODULES_IN_LIBRARY command appears to only > allow you > > to save the footprints in the current board to a library already > listed > > in the footprint library table. I'm not sure this is necessary since > > you could easily select an existing pretty footprint library (in the > > footprint library table or otherwise) and overwrite it without > limiting > > the choices to the footprint library table. The best description I > can > > think of for this is "Archive Footprints in Footprint Library Table > > Entry". This would a least be accurate. > > > > The ID_MENU_CREATE_LIBRARY_AND_ARCHIVE_MODULES command appears to > allow > > you to save the footprints in the current board to either a new > library > > path chosen by the user or overwrite an existing pretty footprint > > library. I would think that this option alone would be sufficient > but > > maybe I'm not seeing why the command above needed. The best > description > > I can think of for this is "Archive Footprints in Library". You > could > > use this option to perform the same operation above. > > > > It seems to med a better approach would be to just have a single > archive > > command and prompt the user for either a library table entry or > library > > path. At least this would be easier to understand for the user. I > > didn't write this code so maybe I am missing something. > > > > On 8/9/2017 6:24 AM, Fabrizio Tappero wrote: > > > Hello, > > > I am tinkering the appearance of some icons and I would like to > > improve > > > the following menu by adding specific archive icons and make some > > of the > > > text a little clearer. > > > > > > This is the current code: > > > > > > //----- archive submenu > > > ----------------------------------------------------- > > > wxMenu* submenuarchive = new wxMenu(); > > > > > > AddMenuItem( submenuarchive, ID_MENU_ARCHIVE_MODULES_IN_ > LIBRARY, > > > _( "&Archive Footprints in Project Library." ), > > > _( "Archive footprints in existing library in > > footprint > > > Lib table" > > > "(does not remove other footprints in this > > library)" ), > > > KiBitmap( library_update_xpm ) ); > > > > > > AddMenuItem( submenuarchive, > > ID_MENU_CREATE_LIBRARY_AND_ARCHIVE_MODULES, > > > _( "&Create Library and Archive Footprints." ), > > > _( "Archive all footprints in new library\n" > > > "(if the library already exists it will be > > deleted)" ), > > > KiBitmap( library_xpm ) ); > > > > > > AddMenuItem( aParentMenu, submenuarchive, > > > ID_MENU_ARCHIVE_MODULES, > > > _( "Arc&hive Footprints" ), > > > _( "Archive or add footprints in library file" ), > > > KiBitmap( library_xpm ) ); > > > > > > I would propose these changes: > > > > > > _( "&Archive Footprints in Default Project Library" ), > > > _( "Archive all footprints in existing default project library > file" > > > "(does not remove other footprints in this library)" ), > > > "(the content of default library is maintained)" ), > > > > > > _( "&Create New Library and Archive Footprints" ), > > > _( "Archive all footprints in new library file\n" > > > "(if library file already exists its content is rewritten)" ), > > > > > > _( "Arc&hive Footprints" ), > > > _( "Archive or add footprints in library file" ), >> _( "Archive > all > > > footprints in library file" ), > > > > > > For the option "Create New Library and Archive Footprints" I think > > it is > > > not clear what library file will be used. Default Project Library > > sounds > > > good to me but I dont think there is a default project library. > > > > > > Any feedback is welcome > > > cheers > > > Fabrizio > > > > > > > > > > > > _______________________________________________ > > > Mailing list: https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > > Post to : [email protected] > > <mailto:[email protected]> > > > Unsubscribe : https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > > More help : https://help.launchpad.net/ListHelp > > <https://help.launchpad.net/ListHelp> > > > > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > Post to : [email protected] > > <mailto:[email protected]> > > Unsubscribe : https://launchpad.net/~kicad-developers > > <https://launchpad.net/~kicad-developers> > > More help : https://help.launchpad.net/ListHelp > > <https://help.launchpad.net/ListHelp> > > > > >
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
