Yep. Looks good.
> On 15 Feb 2018, at 13:46, Michael Kavanagh <[email protected]> wrote: > > Was this what you meant? > > On 15 February 2018 at 11:15, Jeff Young <[email protected] > <mailto:[email protected]>> wrote: > Hi Michael, > > Only thing I found wrong was that you have Sketch & Wireframe zones backwards: > > Wireframe == ID_TB_OPTIONS_SHOW_ZONES_DISABLE > > Sketch == ID_TB_OPTIONS_SHOW_ZONES_OUTLINES_ONLY > > On the opinion side, the Inspect menu is growing on me. So if no one else > has objections to it, then I’ll shut up. ;) > > Cheers, > Jeff. > > >> On 15 Feb 2018, at 01:00, Michael Kavanagh <[email protected] >> <mailto:[email protected]>> wrote: >> >> Lets start with these for now. Patches address a spelling error in the code, >> edit, file and view menus, removes duplicate items and adds missing tools. >> >> Please let me know your comments. >> >> Regards, >> Michael >> >> On 14 February 2018 at 21:55, Michael Kavanagh <[email protected] >> <mailto:[email protected]>> wrote: >> > Okay thanks. Also I think I messed up even the simple first patch (git >> > n00b over here). Please await an updated patch set. >> > >> > Cheers, >> > Michael >> > >> > On 14 February 2018 at 21:30, Wayne Stambaugh <[email protected] >> > <mailto:[email protected]>> wrote: >> >> Michael, >> >> >> >> For future reference, please try to avoid posting a large patch set like >> >> this. I makes it difficult to comment on them without the email thread >> >> quickly becoming difficult to follow. Also, please make an announcement >> >> on the mailing when making substantial changes like this. You could >> >> have gotten the feedback first which would have saved you some work. >> >> >> >> Thanks, >> >> >> >> Wayne >> >> >> >> On 2/13/2018 5:46 PM, Michael Kavanagh wrote: >> >>> Hi, >> >>> >> >>> I tried to fix up the Pcbnew menu bar a bit so its more "standards >> >>> complaint" with regards to UI and also include options where there are >> >>> toolbar buttons but no menu bar item. >> >>> >> >>> Tried to keep commits small, hence number of patches. >> >>> >> >>> Regards, >> >>> Michael >> >>> >> >>> >> >>> _______________________________________________ >> >>> Mailing list: https://launchpad.net/~kicad-developers >> >>> <https://launchpad.net/~kicad-developers> >> >>> Post to : [email protected] >> >>> <mailto:[email protected]> >> >>> Unsubscribe : https://launchpad.net/~kicad-developers >> >>> <https://launchpad.net/~kicad-developers> >> >>> More help : https://help.launchpad.net/ListHelp >> >>> <https://help.launchpad.net/ListHelp> >> >>> >> >> >> >> _______________________________________________ >> >> Mailing list: https://launchpad.net/~kicad-developers >> >> <https://launchpad.net/~kicad-developers> >> >> Post to : [email protected] >> >> <mailto:[email protected]> >> >> Unsubscribe : https://launchpad.net/~kicad-developers >> >> <https://launchpad.net/~kicad-developers> >> >> More help : https://help.launchpad.net/ListHelp >> >> <https://help.launchpad.net/ListHelp> >> >> <0001-Fix-spelling-error.patch><0002-Improve-edit-menu-and-use-common-hotkeys.patch><0003-Fix-up-file-menu-and-hotkeys.patch><0004-Remove-duplicate-track-menu-item.patch><0005-Add-missing-tools-to-menubar.patch><0006-Add-missing-items-to-view-menu-and-improve.patch><0007-Remove-duplicate-menu-item.patch>_______________________________________________ >> Mailing list: https://launchpad.net/~kicad-developers >> <https://launchpad.net/~kicad-developers> >> Post to : [email protected] >> <mailto:[email protected]> >> Unsubscribe : https://launchpad.net/~kicad-developers >> <https://launchpad.net/~kicad-developers> >> More help : https://help.launchpad.net/ListHelp >> <https://help.launchpad.net/ListHelp> > > <0001-Fix-spelling-error.patch><0002-Improve-edit-menu-and-use-common-hotkeys.patch><0003-Fix-up-file-menu-and-hotkeys.patch><0004-Remove-duplicate-track-menu-item.patch><0005-Add-missing-tools-to-menubar.patch><0006-Add-missing-items-to-view-menu-and-improve.patch><0007-Remove-duplicate-menu-item.patch>
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
