I like this change! I've never liked the fact that objects on invisible layers get selected. Has anyone else had a chance to test this? If there are no objections, I recommend that this patch get merged for rc2.
On 2/26/2018 10:11 PM, Jon Evans wrote: > This patch changes the selection logic for footprints to fix a reported > issue[1] and to make the behavior more logical to me. > > I know that correct selection behavior is something of a personal > preference, so I'm ready to be flamed :-) > > The new behavior: > > A footprint may be selected if: > 1) The corresponding "Footprints" switch is on in the Items tab, AND > 2) One or more of the layers that the footprint draws on is visible > > This means that if all of the layers are turned off, footprints are not > selectable (fixes the bug), but it also means that now footprints can be > selected if any draw layers are visible (for example, if you have only > F.Mask enabled, you can select a footprint that has solder mask and is > on the front layer). > > Before anyone complains, this is only if high-contrast mode is turned > OFF. When it is on, you can still only select items that *only* exist > on that layer (to make moving silkscreen around easier, for example) > > Even though this adds some more for-loops to selection filtering, I have > not noticed any performance hits on some selection of large boards that > I tested. More testing is welcome. > > [1] https://bugs.launchpad.net/kicad/+bug/1751960 > > -Jon > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp