Hey Ian, On 5/31/19 6:13 PM, Ian McInerney wrote: > Attached is a patchset that includes some upgrades to the usability of > cvpcb, namely the following: > > * Include a line below the footprint description giving the URI of the > source library. This allows people to see where the library is from. It > is located in a 3rd line below the footprint description, since I > figured this placement is the least obtrusive. It is also only displayed > for the selection from the footprint list (not the component footprint) > since the description field is not displayed for the component. > (requested in https://bugs.launchpad.net/kicad/+bug/1782805)
I'm OK with this patch but I'm not sure it completely works the way users will expect depending on the footprint filtering. For example, if the library filter is on and I select a symbol that already has an assigned footprint from a different library, no library URI shows up in the status pane. I would expect that the shown library would always be the library of the currently selected symbol. Maybe I'm not understanding the intent of this feature. > > * Implement the ability for the escape key to close the window, since it > has a cancel button on it this seems like a useful feature. This will > prompt the user to save the changes if there are any, and will only > operate when the assignment window has focus, so if escape is pressed in > the footprint viewer window it will not close the main window. > (requested in https://bugs.launchpad.net/kicad/+bug/1830483) I'm fine with this patch although it does not apply cleanly to the master branch. I'll merge it into 5.1 if no one objects. > > * Implement the ability to delete individual footprint associations > using the delete key or a right-click menu option. (requested > in https://bugs.launchpad.net/kicad/+bug/1818883) > > * Implement a cut/copy/paste system for the footprint associations that > operates on a 1->1 or 1->many arrangement. When more than 1 component is > selected for the copy/cut command, only the 1st selected one is used. It > can paste this to any number of selected components. This is also > available through the right-click menu. (requested > in https://bugs.launchpad.net/kicad/+bug/1794883). I like this patch as well. As with patch 2, it does not cleanly apply to the master branch, I suspect users will want undo/redo capability with this because I found myself hitting the undo short cut a couple of times while testing. As is, it's a worthwhile change. I'll merge it into 5.1 if no one objects. > > These changes work for both master and 5.1, and I think would be useful > to include in 5.1.3 (one of those reports requesting the features is > actually already targeted to 5.1.3). > > -Ian > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
