Ian, I merged your patches into the 5.1 branch.
Thanks, Wayne On 6/20/19 6:29 PM, Ian McInerney wrote: > Wayne, > > Here are the rebased patches for 5.1. > > -Ian > > On Thu, Jun 20, 2019 at 10:04 PM Ian McInerney <[email protected] > <mailto:[email protected]>> wrote: > > Wayne, > > Thanks for merging the first patch. I am working on rebasing the > other two to the 5.1 branch, and hope to have them done for you > today (the compilations can take a while on my machine though). > > My plan for the master version is to first transition the existing > cvpcb functions to the tool manager that Jeff put in, then to add > these functions on to the tool manager as appropriate. That way > there is no duplication of the work (since the copy/paste/delete > need to be in the tool manager eventually, this saves having to > rewrite them into it later). I hope to do that over the next week or so. > > -Ian > > On Thu, Jun 20, 2019 at 9:04 PM Wayne Stambaugh > <[email protected] <mailto:[email protected]>> wrote: > > Ian, > > Would you please rebase patches 2 and 3. They no longer apply > cleanly. > I'm going to merge all three patches since they all have bug > reports > filed against them. I will accept patch 1 as is since the bug > report > that it fixes specifically requests the current library path be > displayed rather than the library path of the assigned footprint > of a > symbol. When you get a chance, please update the master branch > versions > so we can keep the behavior the same for v6. > > Thanks, > > Wayne > > On 5/31/19 6:13 PM, Ian McInerney wrote: > > Attached is a patchset that includes some upgrades to the > usability of > > cvpcb, namely the following: > > > > * Include a line below the footprint description giving the > URI of the > > source library. This allows people to see where the library is > from. It > > is located in a 3rd line below the footprint description, since I > > figured this placement is the least obtrusive. It is also only > displayed > > for the selection from the footprint list (not the component > footprint) > > since the description field is not displayed for the component. > > (requested in https://bugs.launchpad.net/kicad/+bug/1782805) > > > > * Implement the ability for the escape key to close the > window, since it > > has a cancel button on it this seems like a useful feature. > This will > > prompt the user to save the changes if there are any, and will > only > > operate when the assignment window has focus, so if escape is > pressed in > > the footprint viewer window it will not close the main window. > > (requested in https://bugs.launchpad.net/kicad/+bug/1830483) > > > > * Implement the ability to delete individual footprint > associations > > using the delete key or a right-click menu option. (requested > > in https://bugs.launchpad.net/kicad/+bug/1818883) > > > > * Implement a cut/copy/paste system for the footprint > associations that > > operates on a 1->1 or 1->many arrangement. When more than 1 > component is > > selected for the copy/cut command, only the 1st selected one > is used. It > > can paste this to any number of selected components. This is also > > available through the right-click menu. (requested > > in https://bugs.launchpad.net/kicad/+bug/1794883). > > > > These changes work for both master and 5.1, and I think would > be useful > > to include in 5.1.3 (one of those reports requesting the > features is > > actually already targeted to 5.1.3). > > > > -Ian > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~kicad-developers > > Post to : [email protected] > <mailto:[email protected]> > > Unsubscribe : https://launchpad.net/~kicad-developers > > More help : https://help.launchpad.net/ListHelp > > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > <mailto:[email protected]> > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
