Once the coding policy violations are fixed and the printf debugging statements are removed, I don't see any show stoppers. I have tested this to see if it breaks msys2 builds so hopefully it's already be tested for that.
Cheers, Wayne On 6/27/19 6:02 AM, Simon Richter wrote: > Hi, > > I've rebased[1] Tom's adaptation of my MSVC branch on top of current > master, seems to compile still[2], except for the usual dependency problems > with the generated lexers[3]. > > In this branch, we have an assembler based libcontext (taken over from > boost) that is in a later commit replaced by Windows Fibers. > > Before I do any further work on this branch: which implementation should we > go with, so I can squash the branch to that state? > > I'd then do some more test builds and also actually run the program once or > twice, so we can get the branch ready for merging. > > Simon > > [1] https://git.launchpad.net/~sjr/kicad/msvc-new > [2] https://jenkins.simonrichter.eu/job/windows-kicad-msvc-tom/8/ > [3] https://jenkins.simonrichter.eu/job/windows-kicad-msvc-tom/9/ > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : [email protected] > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
