http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7138
--- Comment #7 from Chris Cormack <[email protected]> 2011-11-03 09:24:33 UTC --- I don't think we should edit someones patch, and leave their name as the committer. If a follow up is needed, do that, or a counter patch. But editing someones work and leaving it under their name isn't right. This will fail perl::critic tests again now also not ok 5 - Test::Perl::Critic for "acqui/basketgroup.pl" # Failed test 'Test::Perl::Critic for "acqui/basketgroup.pl"' # at /usr/share/perl5/Test/Perl/Critic.pm line 110. # # Perl::Critic found these violations in "acqui/basketgroup.pl": # Expression form of "eval" at line 189, column 9. See page 161 of PBP. (Severity: 5) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
