http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7138
--- Comment #11 from M. de Rooy <[email protected]> 2011-11-03 09:59:27 UTC --- (In reply to comment #10) > Heh, it's not my patch, its Katrin's I just signed off on it :) True of course. > And by changing it, i'd now signed off on yours without even seeing it .. > which > is pretty tricky of me :) Clear. I would only change a patch this way if it is quite trivial. Which seemed to me the case here. But no problem. Just checking the perl critic thing: Where I wrote: "Apparently, it does not conflict with perl critic.", I now see that the original patch just violates the same rule of stringy eval. So, maybe it should be solved differently.. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
