http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #166 from Julian Maurice <[email protected]> ---
(In reply to Jonathan Druart from comment #161)
> 2/ The properties for "borrowers" are not exhaustive
> 3/ Wording: borrowers vs patrons? "Patron" should be used now, especially
> for new code.

Ok, these points need to be fixed

> 4/ this patch set introduces swagger.json but nothing to use it, how is it
> useful?

swagger.json, apart from being the api documentation, is also used by
Mojolicious' plugin Swagger2 to create the routes (map URL to
controller/action) and do some basic type check on input and output. So it is
useful (or at least, used) even without documentation generators like SwaggerUI

> 5/ We need a way to split this json file, it will be a mess to edit!

There is an issue on Github for splitting the JSON spec
https://github.com/jhthorsen/swagger2/issues/33
which was moved to
https://github.com/jhthorsen/json-validator/issues/4
which ends with a commit in master
https://github.com/jhthorsen/json-validator/commit/5d7d9db22b891758ac979cc87f1ab018030df2c2

It seems there is something to test here.

> And something to validate it. We need guidelines.

What kind of validation ?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to