http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799
--- Comment #167 from Kyle M Hall <[email protected]> --- (In reply to Julian Maurice from comment #166) > (In reply to Jonathan Druart from comment #161) > > 2/ The properties for "borrowers" are not exhaustive > > 3/ Wording: borrowers vs patrons? "Patron" should be used now, especially > > for new code. > > Ok, these points need to be fixed Agreed. The external api terminology must be patron / patrons at the least. At some point we need to change Koha::Borrower(s) to Koha::Patron(s) but that is entirely separate and distinct from this work. > > 5/ We need a way to split this json file, it will be a mess to edit! > > There is an issue on Github for splitting the JSON spec > https://github.com/jhthorsen/swagger2/issues/33 > which was moved to > https://github.com/jhthorsen/json-validator/issues/4 > which ends with a commit in master > https://github.com/jhthorsen/json-validator/commit/ > 5d7d9db22b891758ac979cc87f1ab018030df2c2 > > It seems there is something to test here. Agreed. It would be *much* better if we can split this file up. If the Swagger2 version we are using doesn't support it, we may have to table this issue until a newer version is available for us to use with Koha. > > And something to validate it. We need guidelines. > > What kind of validation ? I think a unit test using Test::JSON::is_valid_json should be sufficient. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
