http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946
--- Comment #8 from M. Tompsett <[email protected]> --- Comment on attachment 44295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44295 Bug 14946 - Remove C4::Dates from files acqui/*.pl Review of attachment 44295: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14946&attachment=44295) ----------------------------------------------------------------- You missed a point. I'm assuming that your lack of comment about "Post-fix if required because param('shipmentdate') could be a bad date?" is because this is true. ::: acqui/histsearch.pl @@ +95,4 @@ > } > ); > > +my ( $from_iso, $to_iso ); Nice improvement removing the $d. @@ +102,2 @@ > } > +if ( $input->param('to') ) { ... and yet this says 'to'. You didn't explain why the change, or correct it. @@ -102,2 @@ > } > -if ( $d = $input->param('iso') ) { This says 'iso'... -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
