http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946
--- Comment #9 from Marc Véron <[email protected]> --- Thanks again M.Tompsett for reviewing the code. Sorry for any missing comments from my part. I comment in below. Could you already test the functionality? (In reply to M. Tompsett from comment #8) > Comment on attachment 44295 [details] [review] > Bug 14946 - Remove C4::Dates from files acqui/*.pl > > Review of attachment 44295 [details] [review]: > ----------------------------------------------------------------- > > You missed a point. I'm assuming that your lack of comment about "Post-fix > if required because param('shipmentdate') could be a bad date?" is because > this is true. MV: Yes. > > ::: acqui/histsearch.pl > @@ +95,4 @@ > > } > > ); > > > > +my ( $from_iso, $to_iso ); > > Nice improvement removing the $d. MV: Thanks. BTW my aim is to remove C4:Dates for finally have our official date format dd.mm.yyyy (it is really important) - and not to make the code more elegant. In my very long journey through Koha files I saw a lot of places where such improvements could be done :-) > > @@ +102,2 @@ > > } > > +if ( $input->param('to') ) { > > ... and yet this says 'to'. You didn't explain why the change, or correct it. > > @@ -102,2 @@ > > } > > -if ( $d = $input->param('iso') ) { > > This says 'iso'... MV: It's a fix - there is no incoming param 'iso'. We have a param 'from' and a param 'to' resulting in $from_iso and $to_iso. I tested several times to make sure that my change does not break the behaviour. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
