https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|Signed Off |Failed QA --- Comment #37 from Katrin Fischer <[email protected]> --- Hi Nick, starting with a first code review here: 1) There seem to be a few lines doubled up in AddIssue now: $item->{'issues'}++; if ( C4::Context->preference('UpdateTotalIssuesOnCirc') ) { UpdateTotalIssues($item->{'biblionumber'}, 1); } $item->{'issues'}++; if ( C4::Context->preference('UpdateTotalIssuesOnCirc') ) { UpdateTotalIssues( $item->{'biblionumber'}, 1 ); } 2) This line is a change of behaviour: Before the change was dependent on the system preference - now it will always happen? - CartToShelf( $itemnumber ) if ( C4::Context->preference("ReturnToShelvingCart") ); + CartToShelf( $itemnumber ) if ( $item->{'location'} eq 'CART' && $item->{'permanent_location'} ne 'CART' ); 3) ReturnToShelvingCart is removed from the code, but the system preference is not deleted in the database update. 4) koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js contains strings - those can not be translated (js files can't be in general) 5) Tests are failing for me (run within koha-shell in kohadevbox): kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ perl t/db_dependent/Circulation/issue.t Global symbol "$item" requires explicit package name at /home/vagrant/kohaclone/C4/Items.pm line 635. Global symbol "$item" requires explicit package name at /home/vagrant/kohaclone/C4/Items.pm line 635. Can you please take a look? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
